coreui-vue icon indicating copy to clipboard operation
coreui-vue copied to clipboard

Sidebar Backdrop does not disappear on mobile

Open morganphilo opened this issue 2 years ago • 10 comments

I am using Core UI Pro and have implemented the Sidebar in my app, but on mobile when I close the sidebar the backdrop remains.

Same issue exists on the documentation site:

Go to https://coreui.io/vue/docs/components/sidebar.html on mobile. Expand the menu Tap the backdrop to hide the menu

Present on Android, Firefox and Chrome

morganphilo avatar Jul 13 '22 02:07 morganphilo

same here, although it was said to be fixed in v4.1.1 but I'm not entirely sure if and how I could downgrade coreui and coreui/vue to that version

DGollings avatar Jul 21 '22 14:07 DGollings

What version of @coreui/vue, and @coreui/coreui, do you use?

mrholek avatar Jul 25 '22 16:07 mrholek

@coreui/coreui 4.2.0 @coreui/vue 4.3.0

morganphilo avatar Jul 25 '22 21:07 morganphilo

I see it was fixed in v4.1.1 here as identified by @DGollings but I have that version and it persists.

morganphilo avatar Jul 25 '22 21:07 morganphilo

@morganphilo on which mobile device and browser do you have this issue?

mrholek avatar Jul 28 '22 18:07 mrholek

Backdrop persists: Pixel 6 Firefox and Chrome Pixel 4XL Firefox and Chrome

Backdrop Works IPhone 7+ Safari

morganphilo avatar Jul 28 '22 19:07 morganphilo

Interesting, for me it's a pixel 6 pro with Firefox

On Thu, Jul 28, 2022, at 9:06 PM, Morgan Philo wrote:

Backdrop persists: Pixel 6 Firefox and Chrome Pixel 4XL Firefox and Chrome

Backdrop Works IPhone Safari

— Reply to this email directly, view it on GitHub https://github.com/coreui/coreui-vue/issues/220#issuecomment-1198527646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPQJN24YVS6X3KVHH5MDXTVWLK5HANCNFSM53NENDKQ. You are receiving this because you were mentioned.Message ID: @.***>

DGollings avatar Jul 28 '22 19:07 DGollings

Ah interesting. I dusted off my old Galaxy S5 with Chrome and the backdrop goes away as expected. Must be a Pixel issue.

morganphilo avatar Jul 28 '22 20:07 morganphilo

I experience the issue on an iPhone 13 Pro too, when in portrait mode. If the menu is expanded when in landscape mode, it clears as expected.

I wonder if certain media widths are causing this? Dan

dang-cb avatar Jul 28 '22 20:07 dang-cb

This hasn't been addressed at all, anything under 768px viewport gets stuck on the backdrop because the event's not firing on sidebar dismissal, thus the mutation never fires for changing the value responsible for maintaining visibility.

@mrholek easiest way to reproduce it is to simply use the mobile viewport in dev tools, activating the sidenav, then simply tap any item that pushes a different route view. The backdrop will now persist, and there's no way to take care of it.

I've jumped through all sorts of hoops to fix it, ranging from visibility: hidden, to manually triggering an update through mutations on each route push event through a plugin. Overall, it's been a major headache since coreui 4's arrived.

coderkoala avatar Sep 06 '22 05:09 coderkoala

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions

github-actions[bot] avatar Nov 05 '22 14:11 github-actions[bot]