coreui-vue
coreui-vue copied to clipboard
coreui
CLink emit click's argument contains the mouse events
W/o providing the (native) mouse event no consumer can react accordingly. With this change the mouse event is emitted as first argument in the click event.
https://github.com/coreui/coreui-vue/blob/a5c0ad536950d30cac0ef24fd4982b44a9a1df57/packages/coreui-vue/src/components/link/CLink.ts#L44-L46
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@gfoidl @mrholek what about
emit('click', props.href, mouseEvent)
args order?
@xidedix IMO your suggestion makes more sense, as the mouseEvent can be discarded more easily if not used, and this change is a less breaking-change.
Thanks for the suggestion!
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions