coreui-icons icon indicating copy to clipboard operation
coreui-icons copied to clipboard

Include path for SVG files in Flag icons is incorrect

Open jaydiablo opened this issue 4 years ago • 6 comments

This is similar to #20 but for the Flag icons.

The path defined here: https://github.com/coreui/coreui-icons/blob/master/scss/flag/_core.scss#L14 isn't quite right because the svg folder is actually one level deeper. This error was emitted when transpiling the SCSS:

Syntax Error: ModuleNotFoundError: Module not found: Error: Can't resolve '../svg/flag/cif-ad.svg' in '/project/node_modules/@coreui/icons/scss/flag'

To fix this, I changed this line:

background-image: url(../svg/flag/#{$coreui-icons-prefix}#{$icon}.svg);

to

background-image: url(../../svg/flag/#{$coreui-icons-prefix}#{$icon}.svg);

jaydiablo avatar Jun 10 '20 17:06 jaydiablo

Same issue for CoreUI Icons PRO. Can you fix it. Please

patdec avatar Jul 21 '20 22:07 patdec

Sure, I will check it ASAP

mrholek avatar Jul 21 '20 22:07 mrholek

@mrholek , any update on fixing this (in PRO)? Thanks!

Letrab avatar Aug 21 '20 06:08 Letrab

@jaydiablo @patdec I fixed it in the latest release, can you check if this release is ok?

mrholek avatar Nov 18 '20 22:11 mrholek

@mrholek release 2.0.0-rc.0 isn't accessible from npm registry: https://registry.npmjs.org/@coreui/icons-pro/

patdec avatar Nov 30 '20 09:11 patdec

@mrholek when will be update in npm ? cloning from git is not a suitable option (also spending a lot of disk space)

linkuha avatar Mar 13 '21 05:03 linkuha