CoreShop icon indicating copy to clipboard operation
CoreShop copied to clipboard

Discount Total with Shipping

Open solverat opened this issue 1 year ago • 6 comments

Q A
Bug report? not sure
Feature request? no
BC Break report? no
RFC? yes/no

  • Add a product with price of 200
  • Add voucher cart rule with action Discount Amount:

image

Total stays at 10 (Shipping costs):

image

Since I've selected Total in Apply On, I'm expecting a total of 0.

solverat avatar Jan 11 '24 14:01 solverat

@solverat might this be a priority issue? so the discount is calculated before the shipping is? what happens if you click update cart again?

dpfaffenbauer avatar Jan 11 '24 14:01 dpfaffenbauer

what happens if you click update cart again?

Unfortunately, it stays the same.

solverat avatar Jan 11 '24 14:01 solverat

Fortunately ;) that is good news, so we know nothing shady is going on. I have to debug this to figure it out

dpfaffenbauer avatar Jan 11 '24 14:01 dpfaffenbauer

@solverat I took some time, but I debugged it today. The "Apply On" actually doesn't work anymore since we introduced applying the discounts to the items with item ajdustments. this is intentional for vat reasons. if we have discounts, we have apply them to the items to re-calculate the vat. If we apply more then the cart is worth, we only use as much as possible from the subtotal (subtotal being the total of all items). other adjustments like shipping are not affected, since this only get's applied to items.

My suggested solution: remove the "Apply On" option since it doesn't make sense and doesn't work.

dpfaffenbauer avatar Aug 22 '24 06:08 dpfaffenbauer