rpm-ostree icon indicating copy to clipboard operation
rpm-ostree copied to clipboard

support configuring host to retain more than two deployments

Open dustymabe opened this issue 7 years ago • 12 comments

Right now when you upgrade you get the latest deployment and the previous one you were on so that you can rpm-ostree rollback. It would be nice if we could configure this behavior so that you can keep multiple deployments locally to switch back and forth to for debugging purposes.

AFAICT this is really only useful for debugging.

dustymabe avatar Jan 17 '17 19:01 dustymabe

related: https://github.com/ostreedev/ostree/issues/1460

dustymabe avatar Feb 21 '18 19:02 dustymabe

is this taken care of by https://github.com/ostreedev/ostree/pull/1464 or is there another PR needed?

dustymabe avatar Feb 28 '18 17:02 dustymabe

See this story https://blogs.gnome.org/mclasen/2018/03/22/fedora-atomic-workstation-almost-fool-proof/ for some of the unintended consequences that can occur with the combination of package layering and a fixed number of deployments

matthiasclasen avatar Mar 22 '18 22:03 matthiasclasen

See this story https://blogs.gnome.org/mclasen/2018/03/22/fedora-atomic-workstation-almost-fool-proof/ for some of the unintended consequences that can occur with the combination of package layering and a fixed number of deployments

FWIW, https://github.com/ostreedev/ostree/pull/1960 will fix this.

jlebon avatar Feb 04 '20 19:02 jlebon

This is not only useful for debugging, for one I would like to customize the number of deployments.

andreldmonteiro avatar May 25 '20 21:05 andreldmonteiro

I hate to be that guy, but what is status of this issue?

sandorex avatar Nov 06 '20 22:11 sandorex

I hate to be that guy, but what is status of this issue?

It's not being actively worked on AFAIK. Note that nowadays, there's ostree admin pin to prevent specific deployments from being GC'ed.

jlebon avatar Nov 09 '20 14:11 jlebon

i would also like to see support for this added. pinning definitely is nice, but there are times where i'm futzing around with stuff where i don't realize at the time i should be pinning a safe deployment and by the time i realized i've caused problems for myself i'm 5 deployments deep and the original safe deployment is long gone.

xrishox avatar Oct 06 '22 17:10 xrishox

i would also like to see support for this added. pinning definitely is nice, but there are times where i'm futzing around with stuff where i don't realize at the time i should be pinning a safe deployment and by the time i realized i've caused problems for myself i'm 5 deployments deep and the original safe deployment is long gone.

Adding on to this, it would be potentially nice for an option to not only retain a full set of deployments, but also have any unpinned deployments be GC'ed after an indicated time delay. For example, retain all deployments for 30 days, and any deployment at 30+n days in age would be hit by the GC unless it is marked as pinned.

brettgilio avatar Jul 02 '23 18:07 brettgilio

I like the OSTree approach, running Universal Blue on my laptop and my battle station (Kinoite). However, having only one recovery deployment by default severely limits the ability to recover a system from an unwanted/mis-triggered change.

On the other hand, having to manually pin a deployment before a potentially disruptive upgrade (kernel upgrade, Wayland stack upgrade, etc.) creates significant friction when enabling automatic updates.

Allowing at least a bunch of deployments ready to boot from (i.e., openSUSE MicroOS keeps the last five snapshots by default) would significantly provide more substantial protection.

cig0 avatar Oct 24 '23 20:10 cig0

As another point of comparison, NixOS lets you just type in a number and that's how many it'll keep. It defaults to 100 if you use Grub and infinity if you use systemd-boot (source).

awebeer256 avatar Nov 07 '23 17:11 awebeer256