rpm-ostree icon indicating copy to clipboard operation
rpm-ostree copied to clipboard

RFE: Add a hidden option to `rpm-ostree kargs` to update all existing deployments in place

Open travier opened this issue 4 years ago • 4 comments

Describe the enhancement

Add a hidden option to rpm-ostree kargs to update all existing deployments in place.

Example:

$ sudo rpm-ostree kargs --append-if-missings=rw --all-deployments

This would be useful for: https://fedoraproject.org/wiki/Changes/Silverblue_Kinoite_readonly_sysroot

I will work on this one if there is agreement that this is something we are OK with.

This is also a potential 'good first issue' if someone is interested.

travier avatar Apr 11 '22 12:04 travier

Seems sane to me, although perhaps the CLI flag should only affect deployments with a matching stateroot? Dunno. Probably obscure enough to not matter.

cgwalters avatar Apr 11 '22 15:04 cgwalters

This is what rdcore kargs does, which it makes sense to have native support for in the rpm-ostree stack. Hmm, though I wonder if it should be in ostree instead since it's really common to all ostree consumers. Possibly extending the existing hidden ostree admin instutil set-kargs command.

jlebon avatar Apr 11 '22 15:04 jlebon

Any need to bring this up in the meeting this week?

dustymabe avatar Apr 12 '22 13:04 dustymabe

I mistakenly filed this in the FCOS tracker as I originally wanted to file it in the rpm-ostree tracker. Not sure this is meeting worthy.

travier avatar Apr 12 '22 15:04 travier

This has been implemented in ostree: https://github.com/ostreedev/ostree/issues/2590.

travier avatar Oct 25 '22 13:10 travier