WIP: Print package diff against previously default pending deployment rather than booted

[jlebon]

Still needs some tweaks and tests, though it works at least!

[root@f29-ros ~]# rpm-ostree install vagrant
Checking out tree 03e9fb4... done
...
Added:
  bsdtar-3.3.3-2.fc29.x86_64
  ruby-2.5.3-100.fc29.x86_64
  ruby-irb-2.5.3-100.fc29.noarch
  ruby-libs-2.5.3-100.fc29.x86_64
  rubygem-bigdecimal-1.3.4-100.fc29.x86_64
  rubygem-childprocess-0.5.9-5.fc29.noarch
  rubygem-concurrent-ruby-1.0.5-4.fc29.noarch
  rubygem-did_you_mean-1.2.0-100.fc29.noarch
  rubygem-domain_name-0.5.20180417-2.fc29.noarch
  rubygem-erubis-2.7.0-17.fc29.noarch
  rubygem-ffi-1.9.23-2.fc29.x86_64
  rubygem-hashicorp-checkpoint-0.1.5-2.fc29.noarch
  rubygem-http-cookie-1.0.3-5.fc29.noarch
  rubygem-i18n-1.0.0-2.fc29.noarch
  rubygem-io-console-0.4.6-100.fc29.x86_64
  rubygem-json-2.1.0-106.fc29.x86_64
  rubygem-listen-3.1.5-5.fc29.noarch
  rubygem-log4r-1.1.10-9.fc29.noarch
  rubygem-mime-types-3.1-5.fc29.noarch
  rubygem-mime-types-data-3.2016.0521-5.fc29.noarch
  rubygem-net-scp-1.2.1-9.fc29.noarch
  rubygem-net-sftp-2.1.2-8.fc29.noarch
  rubygem-net-ssh-4.2.0-3.fc29.noarch
  rubygem-netrc-0.11.0-4.fc29.noarch
  rubygem-openssl-2.1.2-100.fc29.x86_64
  rubygem-psych-3.0.2-100.fc29.x86_64
  rubygem-rb-inotify-0.9.7-6.fc29.noarch
  rubygem-rdoc-6.0.3-3.fc29.noarch
  rubygem-rest-client-2.0.0-5.fc29.noarch
  rubygem-unf-0.1.4-12.fc29.noarch
  rubygem-unf_ext-0.0.7.5-2.fc29.x86_64
  rubygems-2.7.6-100.fc29.noarch
  rubypick-1.1.1-9.fc29.noarch
  vagrant-2.1.2-3.fc29.noarch
Run "systemctl reboot" to start a reboot
[root@f29-ros ~]# rpm-ostree install ltrace
Checking out tree 03e9fb4... done
...
Added:
  ltrace-0.7.91-28.fc29.x86_64
Run "systemctl reboot" to start a reboot
[root@f29-ros ~]# rpm-ostree status
State: idle
AutomaticUpdates: disabled
Deployments:
  ostree://vmcheck
  └─ Dev overlay on fedora-atomic:fedora/29/x86_64/atomic-host (29.20190306.2; Mar 06 2019)
                 Timestamp: 2019-03-19T02:40:17Z
                BaseCommit: 03e9fb43647a93b010fb500962c16a3ade998e1540a2d8d127100516055d610b
                      Diff: 35 added
           LayeredPackages: ltrace vagrant

● ostree://vmcheck
  └─ Dev overlay on fedora-atomic:fedora/29/x86_64/atomic-host (29.20190306.2; Mar 06 2019)
                 Timestamp: 2019-03-19T02:40:17Z
                    Commit: 03e9fb43647a93b010fb500962c16a3ade998e1540a2d8d127100516055d610b
                  Unlocked: development

One thing this doesn't cover though is --dry-run. I.e. in dry run mode, we still print the full diff. I tried some hacks, though nothing that works super well. Will probably punt on that for now.

Closes: #945

[rh-atomic-bot]

:umbrella: The latest upstream changes (presumably 9e2ceca) made this pull request unmergeable. Please resolve the merge conflicts.

[openshift-ci-robot]

@jlebon: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci[bot]]

@jlebon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/build	56834e6c280a54e686ba2322757a16ca0ddc782b	link	/test build
ci/prow/unit	56834e6c280a54e686ba2322757a16ca0ddc782b	link	/test unit
ci/prow/clang-analyzer	56834e6c280a54e686ba2322757a16ca0ddc782b	link	true	/test clang-analyzer
ci/prow/images	56834e6c280a54e686ba2322757a16ca0ddc782b	link	true	/test images
ci/prow/build-clang	56834e6c280a54e686ba2322757a16ca0ddc782b	link	true	/test build-clang
ci/prow/fcos-e2e	56834e6c280a54e686ba2322757a16ca0ddc782b	link	true	/test fcos-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci[bot]]

@jlebon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/build	56834e6c280a54e686ba2322757a16ca0ddc782b	link	/test build
ci/prow/unit	56834e6c280a54e686ba2322757a16ca0ddc782b	link	/test unit
ci/prow/clang-analyzer	56834e6c280a54e686ba2322757a16ca0ddc782b	link	true	/test clang-analyzer
ci/prow/images	56834e6c280a54e686ba2322757a16ca0ddc782b	link	true	/test images
ci/prow/build-clang	56834e6c280a54e686ba2322757a16ca0ddc782b	link	true	/test build-clang
ci/prow/fcos-e2e	56834e6c280a54e686ba2322757a16ca0ddc782b	link	true	/test fcos-e2e
ci/prow/kola-upgrade	56834e6c280a54e686ba2322757a16ca0ddc782b	link	true	/test kola-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jlebon]

I think this could be neat, but could also confuse users at this point who are used to the current semantics. I don't see myself working more on this.