go-systemd icon indicating copy to clipboard operation
go-systemd copied to clipboard

activation: stub out for plan9

Open flokli opened this issue 1 year ago • 3 comments

plan9 doesn't have syscall.CloseOnExec, causing anything using activation to fail when building on plan9:

2024/05/03 12:12:51 Failed to run [go build --ldflags -s -X github.com/rclone/rclone/fs.Version=v1.67.0-beta.7911.f8ce568ca.merge -trimpath -o rclone-v1.67.0-beta.7911.f8ce568ca.merge-plan9-386/rclone -tags  ..]: exit status 1
2024/05/03 12:12:51 Command output was:
Error: ../../../../go/pkg/mod/github.com/coreos/go-systemd/[email protected]/activation/files_unix.go:60:11: undefined: syscall.CloseOnExec

Seen on https://github.com/rclone/rclone/pull/7801

flokli avatar May 03 '24 16:05 flokli

Another option would be to make this explicitly a linux version, and use the stub everywhere else. Any opinions? @cgwalters @bgilbert

flokli avatar May 25 '24 13:05 flokli