fedora-coreos-docs icon indicating copy to clipboard operation
fedora-coreos-docs copied to clipboard

Build site in CI

Open bgilbert opened this issue 3 years ago • 6 comments

PR CI should run ./build.sh, upload the artifacts somewhere browsable, and post a link in the PR.

bgilbert avatar Feb 11 '22 10:02 bgilbert

I would like to try this

RishiKumarRay avatar Feb 11 '22 10:02 RishiKumarRay

Great! For security, GitHub recommends splitting privileged jobs like this into two pieces, similar to this and this.

@dustymabe, is there a good place we could upload staging content? Maybe we could create an S3 bucket and a token with write access to it?

bgilbert avatar Feb 11 '22 10:02 bgilbert

We could maybe enable GitHub pages here and push to a docs branch with a subpath based on PR number.

travier avatar Feb 11 '22 11:02 travier

I'd rather not fill the production repo with a bunch of test builds. If we want to go the GitHub Pages route, maybe we could create a dedicated repo for that. Even then, it seems a bit awkward for CI runs to live in long-term Git history.

bgilbert avatar Feb 11 '22 11:02 bgilbert

It's also fairly easy to setup GitHub Pages for a forked repo: https://github.com/coreos/fedora-coreos-tracker/blob/main/docs/testing-project-documentation-changes.md

travier avatar Feb 21 '22 12:02 travier

I'd rather not fill the production repo with a bunch of test builds. If we want to go the GitHub Pages route, maybe we could create a dedicated repo for that. Even then, it seems a bit awkward for CI runs to live in long-term Git history.

I agree that having a dedicated testing repo would make sense and would simplify the permission setup while keeping the production repo clean. We could do a periodic cleanup of old branches but I don't think it really matters.

travier avatar Feb 21 '22 12:02 travier