fedora-coreos-config icon indicating copy to clipboard operation
fedora-coreos-config copied to clipboard

release-notes.d: initial directory for release note yaml snippets

Open zonggen opened this issue 5 years ago • 9 comments

This directory stores the Fedora CoreOS release note yaml snippets which will be picked up by fedora-coreos-releng-automation/coreos-release-note-generator [1] script to produce the final release-notes.yaml for a release.

Release notes will be organized according to the origin of the change, i.e. the project name. Otherwise miscellaneous changes will be stored under miscellaneous. Therefore, the schema of each yaml snippet is designed as follows:

# Each yaml file consists of a list of dictionaries which looks like this
- component (required): [Custom Project Name] | miscellaneous
  subject (required): xxx
  body (optional): xxxxx

[1] https://github.com/coreos/fedora-coreos-releng-automation

Related: https://github.com/coreos/fedora-coreos-tracker/issues/194 Signed-off-by: Allen Bai [email protected]

zonggen avatar Aug 07 '20 19:08 zonggen

Updated with a component field instead of enforcing naming convention. Currently thought on component is to support four types of components: [Custom Project Name] | general | bugfix | security.

zonggen avatar Aug 17 '20 20:08 zonggen

Updated with a component field instead of enforcing naming convention. Currently thought on component is to support four types of components: [Custom Project Name] | general | bugfix | security.

I think there might be too much collision there. For example, what if I have a significant bugfix in Ignition? I think we have two options here:

  1. add a type: field with options like enhancement | bugfix | security.
  2. just ignore type: for now and add it later

For component: maybe the word miscellaneous would be better than general. So our options would be component_name | miscellaneous.

dustymabe avatar Aug 18 '20 15:08 dustymabe

Updated the component to allow either [Project Name] or miscellaneous.

zonggen avatar Aug 18 '20 18:08 zonggen

Maybe let's squash the two commits into one?

dustymabe avatar Aug 18 '20 19:08 dustymabe

@dustymabe I formatted the doc a little bit and added an example for the intermediate release-notes.yaml file that consists a next-release field (https://github.com/coreos/fedora-coreos-config/pull/550/files#diff-501cdb98b3adaa694d31c5775aa02a46R14-R29), could you take another look?

zonggen avatar Aug 18 '20 20:08 zonggen

Simplified README.md and squashed commits.

zonggen avatar Aug 19 '20 18:08 zonggen

Will having the example.yaml file make things harder in the implementation? Were you planning to just ignore that file in the code? I like having it there so people can copy and paste, but want to make sure we account for it.

dustymabe avatar Aug 19 '20 20:08 dustymabe

Were you planning to just ignore that file in the code?

@dustymabe Yes, I was writing the releng code such that:

  • empty files are ignored
  • note item with empty component / subject is ignored (since they are required fields)
  • empty body is removed to clean up the final release note

zonggen avatar Aug 20 '20 14:08 zonggen

Will open another PR to next-devel, thanks for the reminder!

EDIT: Opened https://github.com/coreos/fedora-coreos-config/pull/570

zonggen avatar Aug 20 '20 14:08 zonggen