etcd-operator icon indicating copy to clipboard operation
etcd-operator copied to clipboard

Published 20 hours ago • verified publisher icon coreos

ADDED: prometheus exporter for backup-operator

Open jescarri opened this issue 6 years ago • 7 comments

Added prometheus exporter for the etcd-backup-operator.

jescarri avatar Jun 17 '19 20:06 jescarri

Can one of the admins verify this patch?

etcd-bot avatar Jun 17 '19 20:06 etcd-bot

Can one of the admins verify this patch?

etcd-bot avatar Jun 17 '19 20:06 etcd-bot

Can one of the admins verify this patch?

etcd-bot avatar Jun 17 '19 20:06 etcd-bot

Hi @hexfusion any feedback on this PR?

Thanks!

jescarri avatar Jul 03 '19 00:07 jescarri

@hasbro17 @hongchaodeng @xiang90 @fanminshi @rjtsdl

Hey guys sorry for the direct reach, can I get some help on this PR?.

Thanks!

jescarri avatar Jul 09 '19 19:07 jescarri

LGTM overall, can we use basic http rather than introduce garrilia router? My point is, it is not exporting other path except /metrics. A simple http.Handle should be enough.

rjtsdl avatar Jul 09 '19 23:07 rjtsdl

@rjtsdl done, removed the gorilla mux dependency.

jescarri avatar Jul 11 '19 04:07 jescarri