etcd-operator icon indicating copy to clipboard operation
etcd-operator copied to clipboard

Version selection assumes etcd image versions will begin with "v"

Open perotinus opened this issue 7 years ago • 2 comments

The code that constructs the etcd image version from the CRD spec prefixes the image version with a "v". This assumption breaks in some contexts where the released etcd images from quay.io are not beins used, and it would be useful to have a way to tell the operator to take the image version as-is, without inserting the extra "v" into the versioning scheme.

https://github.com/coreos/etcd-operator/blob/7fbe23cf50900e6282255978ae9930a7750d9238/pkg/util/k8sutil/k8sutil.go#L138

perotinus avatar Jun 25 '18 15:06 perotinus

Looks like #1970 addresses this.

perotinus avatar Jun 25 '18 18:06 perotinus

made a PR for the v addition to the version : https://github.com/coreos/etcd-operator/pull/2079

prune998 avatar Apr 17 '19 13:04 prune998