fetch-retries parameter is not working when using a custom coreos-installer invocation

[pamoedom]

Bug

fetch-retries parameter is not working when using a custom coreos-installer invocation.

Host Operating System Version

RHCOS 413.92

Target Operating System Version

RHCOS 413.92

coreos-installer Version

0.17

Expected Behavior

The coreos-installer should replace the --fetch-retries infinite parameter with the custom one.

Actual Behavior

The custom coreos-installer invocation is adding the new fetch-retries parameter but keeping also the default infinite value at the end of the command which overrides the custom one.

Reproduction Steps

1. Create custom installer config:

variant: fcos
version: 1.4.0
storage:
  files:
    - path: /etc/coreos/installer.d/custom.yaml
      contents:
        inline: |
          fetch-retries: 5

2. Convert with butane.
3. Inject the ignition to live ISO or use it via live iPXE booting.
4. Check the coreos-installer-service output:

[   43.194288] coreos-installer-service[1740]: Running with arguments: --ignition-url http://[OBFUSCATED]:8000/rhcos/ignitions/pamoedo-rhcos92/master.ign --console ttyS1,115200n8 --fetch-retries 5 /dev/sda --fetch-retries infinite

Other Information

[bgilbert]

Thanks for the report. I agree that this is not the desired behavior. Out of curiosity, though, why do you want fewer than infinite retries?

[pamoedom]

Hi @bgilbert , thanks for your quick reply.

This issue arose during OCPBUGS-11052 investigation, with infinite retries we can't drop into an emergency shell if the ignition gathering is failing.

Regards.