coreos-assembler icon indicating copy to clipboard operation
coreos-assembler copied to clipboard

Use DPS UUIDs for root and boot partitions

Open Johan-Liebert1 opened this issue 3 weeks ago • 6 comments

Use the Discoverable Partition Specification UUID for root and boot partitions

We were already using DPS UUID for both partitions, but they were UUIDs for generic Linux Data Parition

This lets us use systemd-systemd-gpt-auto-generator which is a good choice for LUKS decryption without UKI addons for composefs backend

Use architecture specific DPS UUID for root partition, and use XBOOTLDR UUID for boot partition

Related: https://github.com/coreos/fedora-coreos-tracker/issues/2060

Closes: https://github.com/coreos/fedora-coreos-tracker/issues/1038

Johan-Liebert1 avatar Dec 02 '25 08:12 Johan-Liebert1

This lets us use systemd-systemd-gpt-auto-generator

Unfortunately we don't include that right now. It got re-introduced recently and broke stuff.

If we were to make this change I think we'd need to make some more careful consideration. Would we want to do it everywhere immediately? Or would we want to phase this in? Right now changes here land downstream in rhel-9.6 pretty much immediately.

cc @travier

dustymabe avatar Dec 02 '25 18:12 dustymabe

It got re-introduced recently and https://github.com/coreos/fedora-coreos-config/pull/3846#issuecomment-3443736766.

iiuc, it broke stuff as gpt-auto-generator searches for partitions via the UUIDs specified in the DPS. kola test locally seemed to pass

The rhcos test does seem to be failing with a timeout.

Johan-Liebert1 avatar Dec 03 '25 09:12 Johan-Liebert1

iiuc, it broke stuff as gpt-auto-generator searches for partitions via the UUIDs specified in the DPS

I see. You're saying this PR fixes that?

dustymabe avatar Dec 03 '25 13:12 dustymabe

I see. You're saying this PR fixes that?

The kola test mentioned https://github.com/coreos/fedora-coreos-config/pull/3846#issuecomment-3443736766 do pass with this patch. This PR might have some cascading effect elsewhere, but from what I saw it shouldn't as this PR only updates partition UUIDs while in our scripts we use the fs UUIDs

Johan-Liebert1 avatar Dec 04 '25 10:12 Johan-Liebert1

/test rhcos

Johan-Liebert1 avatar Dec 04 '25 10:12 Johan-Liebert1

From https://github.com/coreos/fedora-coreos-tracker/issues/1038, first step is to update the UUIDs only and make sure that does not break anything.

Work to use systemd's auto GPT generator tracked in https://github.com/coreos/fedora-coreos-tracker/issues/2077.

We should be able to merge that once we've branched RHEL 9.6.

travier avatar Dec 09 '25 15:12 travier

branching has finished for 9.6 so we can merge this I think.

dustymabe avatar Dec 16 '25 16:12 dustymabe