coreos-assembler icon indicating copy to clipboard operation
coreos-assembler copied to clipboard

cmd-build-with-buildah: remove temporary stream label hack

Open Roshan-R opened this issue 1 month ago • 3 comments

Remove the temporary workaround that manually set the fedora-coreos.stream label during image builds. This label is now applied directly by rpm-ostree through the build process, making the extra logic unnecessary and simplifying cmd-build-with-buildah.

See: https://github.com/coreos/coreos-assembler/issues/4337

Should be able to merge when we get https://github.com/coreos/fedora-coreos-config/pull/3867 merged

Roshan-R avatar Nov 04 '25 07:11 Roshan-R

@Roshan-R: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos e9fcb2e7987c37efc761f4c04a261c60c99a9959 link true /test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 04 '25 07:11 openshift-ci[bot]

/hold let's keep this until we either :

  • make sure we don't use the annotation anymore (zincati)
  • implement annotation support in rpm-ostree

jbtrystram avatar Nov 13 '25 09:11 jbtrystram

yeah, basically we are implementing label support in zincati. Let's hold this until we can get a new zincati release out and a successful FCOS bump with it in there (i.e. two testing releases, since the second release is the first one the new zincati would be used for)

dustymabe avatar Nov 13 '25 20:11 dustymabe