coreos-assembler icon indicating copy to clipboard operation
coreos-assembler copied to clipboard

buildextend-live: Add support OSBUILD

Open ravanelli opened this issue 1 year ago • 1 comments

  • Add support for OSBUILD via COSA_USE_LIVEISO env var for now

ravanelli avatar Aug 19 '24 19:08 ravanelli

Two largish change suggestions:

  1. We consider the "platform" here to be live and not live-iso.

This means platform.live-iso.ipp.yaml -> platform.live.ipp.yaml and that generates the ISO/PXEkernel/initrd/rootfs.

  1. we rename the stage we are proposing to OSBuild to be stages/org.osbuild.coreos.live OR platform.live-artifacts.

dustymabe avatar Nov 18 '24 21:11 dustymabe

Ran this through the differ https://github.com/coreos/coreos-assembler/pull/3968 on FCOS x86_64:

  • We're missing everything in /live in the live ISO. This can be obtained from the container image under /usr/share/coreos-assembler/live (see https://github.com/coreos/coreos-assembler/pull/3846).
  • The osmet filenames in the live rootfs changed from e.g. fedora-coreos-41.20241121.dev.0-1-metal.x86_64.raw.osmet to just metal.osmet and similarly for metal4k. I don't think this breaks anything and we could do without, though having the build ID in the name is a nice cross-check.
  • /boot on the squashfs is missing everything under /boot/efi. We need to mount the ESP onto /boot/efi when building the squashfs like we do in coreos_gf_run_mount.

We should repeat the exercise on other arches.

jlebon avatar Nov 21 '24 20:11 jlebon

successor in https://github.com/coreos/coreos-assembler/pull/3976

dustymabe avatar Nov 26 '24 05:11 dustymabe