coreos-assembler icon indicating copy to clipboard operation
coreos-assembler copied to clipboard
verified publisher icon coreos

testiso/iscsi add a manual test for no iBFT cases

Open jbtrystram opened this issue 1 year ago • 3 comments

This test simply changes the kargs from rd.iscsi.firmware=1 to netroot=iscsi... at the coreos-installer step. This will ensure we support no-ibft installations.

Partial fix for https://github.com/coreos/fedora-coreos-tracker/issues/1651

jbtrystram avatar Mar 13 '24 14:03 jbtrystram

/restest

jbtrystram avatar Mar 14 '24 12:03 jbtrystram

Let's clear up https://github.com/openshift/os/pull/1461#issuecomment-1998858271 before merging this so that we don't immediately break the RHCOS pipeline.

jlebon avatar Mar 15 '24 03:03 jlebon

To confirm, did you verify that this passes on RHCOS?

jlebon avatar Apr 30 '24 19:04 jlebon

To confirm, did you verify that this passes on RHCOS?

tested on rhcos-416.94.202404301731-0-live.x86_64.iso:

Running test: iso-offline-install-iscsi.ibft.bios
PASS: iso-offline-install-iscsi.ibft.bios (3m23.07s)
Running test: iso-offline-install-iscsi.manual.bios
PASS: iso-offline-install-iscsi.manual.bios (3m15.665s)

dustymabe avatar Apr 30 '24 21:04 dustymabe

To confirm, did you verify that this passes on RHCOS?

I think i did at the time, when opening the PR. Thanks @dustymabe for the confirmation

jbtrystram avatar May 01 '24 10:05 jbtrystram