coreos-assembler icon indicating copy to clipboard operation
coreos-assembler copied to clipboard

mantle: overhaul aliyun auth

Open dustymabe opened this issue 3 years ago • 3 comments

The Aliyun SDK has a native file format it can consume for credentials [1]. This commit proposes we use that file format here and drop the custom JSON parsing that we're doing for Aliyun.

This commit also drops the toplevel --config argument in cmd-ore-wrapper because Aliyun was the only consumer of that argument.

[1] https://github.com/aliyun/alibaba-cloud-sdk-go/blob/710fea6cf27cf855f301462a2adcf3399169f63c/docs/2-Client-EN.md#2-credentials-file

dustymabe avatar Oct 27 '22 20:10 dustymabe

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Oct 27 '22 20:10 openshift-ci[bot]

I'm not 100% sure we want to make this change, but I dug into the problem space today and figured I'd propose it if for nothing else than to reference the code in the future if we ever need it.

dustymabe avatar Oct 27 '22 21:10 dustymabe

@dustymabe: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Jan 18 '23 21:01 openshift-merge-robot