coreos
kola: Add `isolation=readonly|dynamicuser`
EDIT: I apologize for the tone in this PR that started from me; it was absolutely unnecessary. Again, I apologize.
Part of my battle against duplicative comments in our kola tests. We have a few tests that write a comment like this:
# - exclusive: false
# - This test doesn't make meaningful changes to the system and
# should be able to be combined with other tests.
Of course, this comment is already redundant because the
meaning of the exclusive tag is defined canonically in coreos-assembler
(here) and copy-pasting that into every test that uses it would
be pointlessly verbose.
But - we can do one better. Instead of having a test flag which
is mainly an "I promise not to mutate the system in a way which could
interfere with other tests", let's add a field that enforces this.
Then it doesn't need to be commented; we have a variety of
tests which are just "system inspection" (e.g. query rpmdb) and
run just fine with DynamicUser=yes and hence cannot affect
the system, and hence are inherently isolated from other concurrent
tests.
@cgwalters: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Closing this. I don't think it's a priority right now. If we want to implement the suggested changes from the discussion let's start with an issue explaining the proposal.
