coreos-assembler icon indicating copy to clipboard operation
coreos-assembler copied to clipboard

implement golangci-lint on mantle code as GH Action

Open miabbott opened this issue 3 years ago • 1 comments

Feature Request

Implement golangci-lint checks on the mantle code for each PR as part of a GH Action

Desired Feature

Configure a GH Action that runs golangci-lint on each PR, similar to what is done for Butane and Ignitioon

Example Usage

$ git clone https://github.com/coreos-assembler
$ pushd coreos-assembler/mantle
$ golanci-lint run -v 

Other Information

Opening this issue to test the appetite for linting the Go code in mantle. I started down the path as a follow-up to https://github.com/coreos/fedora-coreos-tracker/issues/1096 but thought I would see if this was desirable before investing more time.

miabbott avatar Mar 22 '22 14:03 miabbott

SGTM, I think it'd be good to not run it as part of make check and stop downloading/building it there by default at least.

cgwalters avatar Mar 22 '22 19:03 cgwalters