Warning partitions cannot be reused by label

[chris-neely]

When using the advanced example in the config documentation it gives a number of warnings on v1.6.0. When changing to 1.5.0 these warnings are not present. When checking the 1.5.0 to 1.6.0 upgrade documentation it states that all configs should be able to be used from 1.5.0. I'm attempting a similar configuration to t his in my own file but also receive the same warning.

Is it safe to use this configuration with the resulting warnings or will it cause some ill effects in future versions?

Config:

variant: fcos
version: 1.6.0
boot_device:
  luks:
    tpm2: true
  mirror:
    devices:
      - /dev/sda
      - /dev/sdb
storage:
  disks:
    - device: /dev/sda
      partitions:
        # Override size of root partition on first disk, via the label
        # generated for boot_device.mirror
        - label: root-1
          size_mib: 10240
        # Add a new partition filling the remainder of the disk
        - label: var-1
    - device: /dev/sdb
      partitions:
        # Similarly for second disk
        - label: root-2
          size_mib: 10240
        - label: var-2
  raid:
    - name: md-var
      level: raid1
      devices:
        - /dev/disk/by-partlabel/var-1
        - /dev/disk/by-partlabel/var-2
  luks:
    - name: var
      device: /dev/md/md-var
      # No key material is specified, so a random key will be generated
      # and stored in the root filesystem
  filesystems:
    - device: /dev/mapper/var
      path: /var
      label: var
      format: xfs
      wipe_filesystem: true
      with_mount_unit: true

Resulting warnings:

warning at $.storage.disks.0.partitions.0.number, line 16 col 11: partitions cannot be reused by label; number must be specified except on boot disk (/dev/disk/by-id/coreos-boot-disk) or when wipe_table is true
warning at $.storage.disks.0.partitions.1.number, line 19 col 11: partitions cannot be reused by label; number must be specified except on boot disk (/dev/disk/by-id/coreos-boot-disk) or when wipe_table is true
warning at $.storage.disks.1.partitions.0.number, line 23 col 11: partitions cannot be reused by label; number must be specified except on boot disk (/dev/disk/by-id/coreos-boot-disk) or when wipe_table is true
warning at $.storage.disks.1.partitions.1.number, line 25 col 11: partitions cannot be reused by label; number must be specified except on boot disk (/dev/disk/by-id/coreos-boot-disk) or when wipe_table is true
Config produced warnings and --strict was specified

[prestist]

@chris-neely hey! thank you for submitting this issue; First off sorry for the confusing wording here; While it is still true " that all configs should be able to be used from 1.5.0." the warning is now present because it was going un-dectected in 1.5.0 and bellow. If you want to read the details here.

That being said, your config will still act the same way it did in 1.5.0; however in light of #377 it might be good to update your config to not re-use by label as there is a chance that unknowingly were interacting with different partitions as described on #377.