handle efi vendordir better

[cgwalters]

See https://github.com/rhinstaller/anaconda/pull/5508#issuecomment-2000443423 and previous

Basically during an installation process we should really fix things so that we find the EFI vendor for the shim/grub we're going to install (from /usr/lib/bootupd/updates/EFI), verify its presence in the real ESP, and then target that.

[jkonecny12]

I see this is closed. Does that mean that the bootupd installed by Anaconda will work on dual boot or more adjustments are required?

[HuijingHei]

Does that mean that the bootupd installed by Anaconda will work on dual boot or more adjustments are required?

Not quite sure, this issue is only to make sure to find the vendor directory (and shim path) and will not break creating the EFI boot manager entry. Maybe @cgwalters has more context about your question.

[travier]

https://github.com/coreos/bootupd/pull/633 helped but is not complete. There are cases where could have multiple shim binaries in the EFI partition and we only want to touch our own, not others.

The logic should be:

• Look at what we have in: /usr/lib/bootupd/updates/EFI/foo/bar
• Find the corresponding file in the EFI partition: /boot/efi/EFI/foo/bar
• Update the file if needed

[HuijingHei]

#633 helped but is not complete. There are cases where could have multiple shim binaries in the EFI partition and we only want to touch our own, not others.

The logic should be:

• Look at what we have in the image
• Find the corresponding in the EFI partition
• Update only that

For example, firstly find the <vendor>/shimx64.efi file under /usr/lib/bootupd/updates/EFI/, then find it under EFI partition, if they are the same, then get the shim path; if not, will fail. Is this correct?

[travier]

I've edited my comments to try to clarify it

[HuijingHei]

Thanks @travier for the clarification!

[travier]

With https://github.com/coreos/bootupd/pull/650 merged, I think we can consider this one fixed. We'll have to test it again. Thanks @HuijingHei