best-practices-badge
best-practices-badge copied to clipboard
Bump bootstrap_form from 2.7.0 to 5.1.0
Bumps bootstrap_form from 2.7.0 to 5.1.0.
Release notes
Sourced from bootstrap_form's releases.
5.0.0
Breaking changes
- Generates markup for Bootstrap 5.
New features
- #572: Simplify the formatting of the file upload control to follow the new Bootstrap 5 styles
- #573: Add support for Bootstrap 5's floating labels
Bugfixes
- #582: Fix tests in bootstrap-5 branch, removes Rubocop offenses, and adds testing with Rails 6.1.
4.5.0
New features
- #562: Allow to configure default form attributes -
@sharshenov.
... (truncated)
Changelog
Sourced from bootstrap_form's changelog.
Change Log
Apology
The tooling to support our old way of doing the change log doesn't work anymore, and we don't have a better solution, so this change log has become unreliable since version 4.5.0. Please refer to the commit history if you need to debug changes.
- Pending Release
- 5.1.0
- 5.0.0
- 4.5.0
- 4.4.0
- 4.3.0
- 4.2.0
- 4.1.0
- 4.0.0
- 4.0.0.alpha1
- 2.7.0
- 2.6.0
- 2.5.3
- 2.5.2
- 2.5.1
- 2.5.0
- 2.4.0
[Pending Release][]
Breaking changes
New features
#572: Simplify the formatting of the file upload control to follow the new Bootstrap 5 styles
#573: Add support for Bootstrap 5's floating labels
#215: Add
include_hiddenoption tocheck_boxBugfixes
- #582: Fix tests in bootstrap-5 branch, removes Rubocop offenses, and adds testing with Rails 6.1.
[5.0.0.alpha1][]
Breaking changes
- #569 Remove
role="form"from the default generated form HTML so forms pass W3C validation. (Only a breaking change if you depended on theformattribute.bootstrap_formdoesn't depend on it.)New features
... (truncated)
Commits
9e4e995Preparing v5.1.0d904d06Remove chandler45e3856Fix rubocop offences6739cd7Allow setting wrapper attributes for check boxes and radios buttons1446613Added README example forrange_field1496080Use docker-compose (#644)b91891cNeed 7.0.2 for file upload test (#643)06ca84aAdd support for append and prepend on collection_select (fixes #428) (#641)5755a39Update the generated HTML for the trix editor example1a0e3f6Update the inline form layout- Additional commits viewable in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Codecov Report
Patch coverage has no change and project coverage change: +49.78 :tada:
Comparison is base (
74f9f41) 50.21% compared to head (d88a584) 100.00%.
:exclamation: Current head d88a584 differs from pull request most recent head a666000. Consider uploading reports for the commit a666000 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #1818 +/- ##
============================================
+ Coverage 50.21% 100.00% +49.78%
============================================
Files 53 53
Lines 2322 2078 -244
============================================
+ Hits 1166 2078 +912
+ Misses 1156 0 -1156
see 40 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This one should probably have some visual inspection by someone familiar with where the app keeps its forms and views @david-a-wheeler
The challenge is that we use a version of bootstrap a major version less than current, so there may be subtle issues.
Our test suite emphasizes the server API. We do test against the UI via a web browser, but updating bootstrap (and bootstrap_form) is an area where simply "passing the test suite" might not be good enough. Of course, that means that the "test suite isn't good enough" but it's really hard to anticipate what humans expect. I suggest some human testing before merging this change.
I agree - probably the best way would be to walk through the app itself and demo it to make sure it looks ok in the actual app flow. We could either pair up and do it over zoom, or if you have a list of flows and instructions on usage to check I can try it
Superseded by #1969.