best-practices-badge icon indicating copy to clipboard operation
best-practices-badge copied to clipboard

Improve handling of private GitHub repos

Open david-a-wheeler opened this issue 3 years ago • 0 comments

If someone adds a GitHub repo that's private, we handle it correctly externally but through exception handlers. This creates absurdly long log entries like this:

Jan 01 22:20:13 production-bestpractices app/web.1: ERROR:: In method propose_one_change, exception no implicit conversion of String into Integer on RepoFilesExamineDetective, current_proposal= {:

We don't need all that logging for this case; simplify things. We could return more information in this case.

david-a-wheeler avatar Jan 03 '22 16:01 david-a-wheeler