hookshot icon indicating copy to clipboard operation
hookshot copied to clipboard

Acknowledge webhook creation ping

Open mhkeller opened this issue 9 years ago • 3 comments

GitHub sends a ping even on Webhook creation: https://developer.github.com/webhooks/#ping-event

But since it doesn't follow the structure that lib/index.js is expecting, that script throws an error, such as when it can't find a string for payload.ref.

You could do fancier things to handle this such as emit a ping event but this fix will stop the script from breaking for now.

mhkeller avatar Nov 10 '14 17:11 mhkeller

Checking in on this.

mhkeller avatar Jun 18 '15 00:06 mhkeller

@mhkeller if you're still using this library, I've created a fork which supports Ping events and has unit tests.

Check it out at: https://www.npmjs.com/package/githooked

ScottONeal avatar Feb 07 '16 20:02 ScottONeal

@ScottONeal awesome!

mhkeller avatar Feb 07 '16 21:02 mhkeller