coredns
coredns copied to clipboard
forward: respect context
1. Why is this pull request needed and what does it do?
- Stop useless query attempts when context is already expired.
- Allows to control effective forward timeout with
cancelplugin.
2. Which issues (if any) are related?
Related #4493
3. Which documentation changes (if any) need to be made?
None, it's close to correct behaviour we would naturally expect.
4. Does this introduce a backward incompatible change or deprecation?
No, there is no way one could successfully query some server relying on canceled context as base context for their queries.
Codecov Report
Attention: 770 lines in your changes are missing coverage. Please review.
Comparison is base (
93c57b6) 55.70% compared to head (0d3b3ca) 58.46%. Report is 1125 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #6483 +/- ##
==========================================
+ Coverage 55.70% 58.46% +2.76%
==========================================
Files 224 252 +28
Lines 10016 16568 +6552
==========================================
+ Hits 5579 9687 +4108
- Misses 3978 6290 +2312
- Partials 459 591 +132
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.