coredns.io icon indicating copy to clipboard operation
coredns.io copied to clipboard

hero, header and footer look-feel improvements

Open reveurguy opened this issue 2 years ago • 20 comments

Signed-off-by: reveurguy [email protected] Made initial improvements to the website by making changes in hero section, header and footer. Please provide any feedback or changes. Will make improvements to the rest of the website as well.

Thank you for contributing to CoreDNS' website!

Note:

Any pull request that updates either of those should be directed to the CoreDNS repository: https://github.com/coredns/coredns .

reveurguy avatar Jun 27 '22 15:06 reveurguy

Please put a description of the changes you are making in the PR Description.

chrisohaver avatar Jun 27 '22 19:06 chrisohaver

I have mentioned the changes.

reveurguy avatar Jun 29 '22 06:06 reveurguy

I have mentioned the changes.

“Made initial improvements to the website by making changes in hero section, header and footer.”

This is too vague. Please describe the changes.

chrisohaver avatar Jun 29 '22 11:06 chrisohaver

Made initial changes to improve the website look and design.

  1. I changed the background of the header, hero section and footer.
  2. Improved the navbar look and added twitter, slack and github links as logos.
  3. Improved the hero section buttons looks and style, also improved the version-release notes section look.

reveurguy avatar Jun 29 '22 11:06 reveurguy

@chrisohaver I have made more changes to the homepage. Now it is fully improved. please have a look at it and do provide me any feedback or suggestions.

reveurguy avatar Jun 30 '22 12:06 reveurguy

This is a pretty significant re-design ... reviewing a change of this scope isn't my wheelhouse.

Maybe a website-designy person from CNCF can help review the proposed new look?

chrisohaver avatar Jun 30 '22 13:06 chrisohaver

I didn't understand what you meant by CNCF resource.

reveurguy avatar Jun 30 '22 14:06 reveurguy

On the whole, I prefer the existing cold condensed presentation over the more whimsical proposed design. This is just my preference. That said the website isn't made for me (a CoreDNS maintainer); it exists for other people (new CoreDNS users), and I don't know what their preference is.

chrisohaver avatar Jun 30 '22 18:06 chrisohaver

We can share the website in the slack channel and ask other maintainers and members for their view. That would help.

reveurguy avatar Jun 30 '22 18:06 reveurguy

This is a pretty significant re-design ... reviewing a change of this scope isn't my wheelhouse.

Maybe a website-designy person from CNCF can help review the proposed new look?

Yes we can do that as well if you want.

reveurguy avatar Jul 01 '22 06:07 reveurguy

@bradbeam @chrisohaver @dilyevsky @jameshartig @greenpau @isolus @johnbelamaric @miekg @pmoroney @rajansandeep @stp-ip @superq @yongtang @Tantalor93

Please see this proposed redesign of coredns.io, and provide feedback:

https://deploy-preview-267--coredns.netlify.app

chrisohaver avatar Jul 20 '22 15:07 chrisohaver

On my phone it is quite a regression in a UX F85DD09C-FE1D-4036-A4C2-C792FCDEC3F4 I cant even see the header

Tantalor93 avatar Jul 20 '22 15:07 Tantalor93

On my phone it is quite a regression in a UX

Thanks for taking a look! I noticed the mobile display issues too. Although I think we should make sure there is a consensus to move forward with the proposed look and feel before spending time ironing out bugs in the new design.

chrisohaver avatar Jul 20 '22 15:07 chrisohaver

These are the initial changes only, so i made it w.r.t to laptop size only, haven't made it responsive, that's why it will not look good on mobile, would be visible perfectly on laptop.

reveurguy avatar Jul 20 '22 15:07 reveurguy

On the whole, I prefer the existing cold condensed presentation over the more whimsical proposed design. This is just my preference. On the whole, I prefer the existing design over the proposed design.

I fall into this bucket as well. Some general comments/opinions,

  • I find the gradient header to be very busy and sometimes hides/obscures the text/links ( ex, on the plugins page, the text under Plugins; when hovering over the Documenting Plugins link, the box nearly disappears )
  • The shadow(?) under the landing page topics made me think I had the text selected; I find it a bit distracting
  • I do like the CNCF graduation banner

bradbeam avatar Jul 20 '22 19:07 bradbeam

On the whole, I prefer the existing cold condensed presentation over the more whimsical proposed design. This is just my preference. That said the website isn't made for me (a CoreDNS maintainer)

I'll go along with that as well.

Also, I'm not sure what problem the new design is supposed to solve. Functionally it seems to be similar. And compared to other sites that have a design that is deemed modern, the old design seems more modern to me than the proposal.

Isolus avatar Jul 20 '22 21:07 Isolus

Also, I'm not sure what problem the new design is supposed to solve

+1 unless there's a specific issue we're trying to address my preference is to keep it as is.

dilyevsky avatar Jul 20 '22 21:07 dilyevsky

if required I can make the changes suggested, these were only the initial changes so most of them were on the landing page itself, that's why on other pages there would be some issues. my suggestion and changes were just to make the site look visually better, it doesn't solve any major problem. if you would like to remain with the current site, i'll close this PR, that's no issue.

reveurguy avatar Jul 21 '22 02:07 reveurguy

Screenshot 2022-07-21 at 8 09 45 AM Screenshot 2022-07-21 at 8 10 07 AM

reveurguy avatar Jul 21 '22 02:07 reveurguy

I think it seems that the general agreement is to keep the UI of the site as it is, so I think we can close this @reveurguy ? But thanks for the time you spent on this overhaul. Do you agree with closing this PR and keep the site as it is? @chrisohaver @dilyevsky @bradbeam

Tantalor93 avatar Sep 25 '22 11:09 Tantalor93