dma icon indicating copy to clipboard operation
dma copied to clipboard

Split body of mails not respecting RFC2822

Open bapt opened this issue 9 years ago • 8 comments

For mails where the body does not respect RFC2822, try to split by words finding the last space before 1000's character

If no spaces are found then consider the mail to be malformed anyway

This should address #18

bapt avatar Oct 20 '16 21:10 bapt

If we split some lines, I think we should split all lines. For simplicity's sake, I'd split them strictly at byte 990 or so...

corecode avatar Oct 20 '16 21:10 corecode

So you want me to remove the discovery of the space and always split long lines?

bapt avatar Oct 20 '16 21:10 bapt

done

bapt avatar Oct 20 '16 21:10 bapt

I think I addressed all the comments

bapt avatar Oct 31 '16 20:10 bapt

Ping?

emaste avatar Feb 22 '17 18:02 emaste

We ran into unexpected issues that this would fix when trying to switch to dma. For instance, cron jobs would fail if there was a long line on stdout/stderr as it gets piped to sendmail.

kev009 avatar Aug 26 '17 02:08 kev009

Just wanted to comment that while this PR seems to still apply cleanly, when we deployed it we instantly had complaints about some automated emails getting rejected with a corrupted queue error, so failing this check:

https://github.com/corecode/dma/blob/master/net.c#L582

I sadly never got a copy of one in order to replicate the issue on-demand, so we just reverted the patch for now. If I find a way to replicate the issue, I'll dig some more into this.

jailbird777 avatar Feb 20 '20 20:02 jailbird777

Hi @jailbird777

Regarding your comment on on 20 Feb 2020, can you try to replicate your issue with instructions on FreeBSD PR266629 ?

And, if running FreeBSD, you can also try corresponding patches.

mslehto avatar Sep 29 '22 08:09 mslehto