corde icon indicating copy to clipboard operation
corde copied to clipboard

fix(reader): support configs with .cjs extension

Open AverageHelper opened this issue 2 years ago • 2 comments

Not ESM support, but a solid workaround.

Fixes #1428.

AverageHelper avatar Aug 06 '22 01:08 AverageHelper

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 06 '22 01:08 sonarqubecloud[bot]

Codecov Report

Merging #1429 (1b1b25f) into master (049d7e7) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1429   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files          95       95           
  Lines        2743     2743           
  Branches      594      594           
=======================================
  Hits         2484     2484           
  Misses        259      259           
Impacted Files Coverage Δ
src/core/reader.ts 86.84% <100.00%> (ø)

codecov[bot] avatar Aug 06 '22 01:08 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Nov 16 '22 23:11 sonarqubecloud[bot]

Hi @AverageHelper. Well... I was off from this project for a while, but I am finally back. Thank you so much for the contribution and sorry for the delay. <3

lucasgmagalhaes avatar Nov 16 '22 23:11 lucasgmagalhaes

Glad to have you back!

AverageHelper avatar Nov 16 '22 23:11 AverageHelper