samples
samples copied to clipboard
Negotiation CorDapp Missing a Time-window
- In the Negotiation CorDapp both
ProposalState
andTradeState
belong to the same contractProposalAndTradeContract
. - Inside the contract, it mandates for
Propose
command that there should be a time-window (see here). - But
proposalFlow
(which usesPropose
command for the transaction) doesn't add a time-window; so the transaction verification would definitely fail (see here). - Btw, the above mentioned flow doesn't call
tx.verify()
before signing the transaction (see here).
Update: AcceptanceFlow
and ModificationFlow
don't add a time-window either; even though it's required by the contract.