samples icon indicating copy to clipboard operation
samples copied to clipboard

Negotiation CorDapp Missing a Time-window

Open adelrustum opened this issue 4 years ago • 1 comments

  • In the Negotiation CorDapp both ProposalState and TradeState belong to the same contract ProposalAndTradeContract.
  • Inside the contract, it mandates for Propose command that there should be a time-window (see here).
  • But proposalFlow (which uses Propose command for the transaction) doesn't add a time-window; so the transaction verification would definitely fail (see here).
  • Btw, the above mentioned flow doesn't call tx.verify() before signing the transaction (see here).

adelrustum avatar Apr 23 '20 17:04 adelrustum

Update: AcceptanceFlow and ModificationFlow don't add a time-window either; even though it's required by the contract.

adelrustum avatar Apr 23 '20 17:04 adelrustum