samples icon indicating copy to clipboard operation
samples copied to clipboard

Serialization of whitelisted custom data classes without annotation in MockNetwork

Open MikkelThomsen opened this issue 4 years ago • 2 comments

Hi.

In https://github.com/MikkelThomsen/samples I have added an example of a contract that uses a custom data class and runs a MockNetwork using that class. See cordapp-example/workflows-kotlin/src/test/kotlin/com/example/test/contract/IOUContractTests.kt. The data class is whitelisted, but not annotated with @CordaSerializable.

When running the test, it fails with Class "class com.example.data.IOUData" is not on the whitelist or annotated with @CordaSerializable.'. If I annotate it, the test succeeds.

I have added a META-INF/services/net.corda.core.serialization.SerializationWhitelist with a reference to the class that extends SerializationWhitelist.

As far as i can see, JarScanningCordappLoader#findWhitelists checks whether the whitelist has the same location as the CorDapp, but the whitelist implementation is picked up from the classpath instead. The expected location is within the created mockNetwork folder and not the project classpath.

Is there something in either the gradle dependency setup or the whitelist specification that I am doing wrong?

Sincerely Mikkel

MikkelThomsen avatar Apr 16 '20 12:04 MikkelThomsen

It seems like it is the same issue we are facing in https://github.com/corda/corda/issues/5914

MikkelThomsen avatar Apr 17 '20 08:04 MikkelThomsen

It seems like this is the same issue: https://r3-cev.atlassian.net/browse/CORDA-3643

MikkelThomsen avatar Apr 23 '20 06:04 MikkelThomsen