samples-java icon indicating copy to clipboard operation
samples-java copied to clipboard

CollectSignatureFlow not needed in worldcupticketbooking/DVPAccountsOnSameNode.java

Open alebaffa opened this issue 4 years ago • 0 comments

Hi,

following up this question on StackOverflow. Since the signers are all accounts all in the same node, the CollectSignatureFlow should not be needed. The comment in the source code of this example is either in contrast with what the Account Library documentation says or the documentation needs to be clarified to avoid confusion to learners.

https://github.com/corda/samples-java/blob/33773eb0deb95e8ca8bdcf91c3b3f56bfb57b0b1/Accounts/worldcupticketbooking/workflows/src/main/java/com/t20worldcup/flows/DVPAccountsOnSameNode.java#L161

alebaffa avatar Nov 03 '20 00:11 alebaffa