corda-training-template icon indicating copy to clipboard operation
corda-training-template copied to clipboard

Published 20 hours ago • verified publisher icon corda

Invalid check of IOUState on full settlement flow

Open ooharawork opened this issue 6 years ago • 0 comments

https://github.com/corda/corda-training-template/blob/9adee329f4b616ecac7c393582c09bca233a798c/kotlin-source/src/main/kotlin/net/corda/training/flow/IOUSettleFlow.kt#L49-L52

In the case of full settlement, the transaction must not contain an IOUState in output, therefore the code above produces an error.

The check should be removed as in corda-training-solutions, or modified such that the check is made only when in a partial settlement.

BTW I don't have much expertise on Corda so not sure but, I doubt that that check is really required here, because we have already similar checks in IOUContract.

ooharawork avatar Aug 15 '18 09:08 ooharawork