message_highlight icon indicating copy to clipboard operation
message_highlight copied to clipboard

Is this plugin known to work with roundcube 1.4.13?

Open jonhnet opened this issue 2 years ago • 2 comments

Hi there, I plugged this into my fairly vanilla debian bullseye roundcube; no other plugins. I can add rows to the Message Highlights table, but nothing changes in the message list display. I tried adding console.log(message) to mh_insert_row() in the .js file. I can see dozens of rows in the browser console, but none have the .flags field that the js is expecting:

    // check if our color info is present
    if(message.flags && message.flags.plugin_mh_color) {

It looks like the php is trying to populate that field inside mh_highlight(). I tried shoving my own field in unconditionally:

      $message->list_flags['extra_flags']['plugin_mh_jonh'] = 'xxx-jonh';

...and that doesn't show up in the browser JS console, either. So now I'm suspecting that the path from PHP 'extra_flags' to JS .flags has changed somewhere along the line, which makes me wonder whether I'm trying to debug something that has simply fallen behind the current roundcube hooks?

Thanks much!

jonhnet avatar Jan 22 '23 22:01 jonhnet

This project seems to be dead. Try to use my fork if you wish: https://github.com/melroy89/message_highlight

melroy89 avatar Feb 17 '25 23:02 melroy89

@melroy89 Thank you! That worked instantly, as advertised. I've been wanting this feature forever!

jonhnet avatar May 09 '25 21:05 jonhnet