corbinSanders

Results 7 comments of corbinSanders

[ENG-1747] Upgrade GitHub3.py library to 1.3.0

> @corbinSanders What about [these lines](https://github.com/CenterForOpenScience/osf.io/blob/develop/Dockerfile#L70-L71) ? 👌

[ENG-114] Fix for non-sequential version identifiers

LGTM!

[ENG-367][Part 1] Use pre-commit to format more of codebase

Hooray for linting! ⭐️

[ENG-2398] Make figshare work with new public private rules

LGTM!

[ENG-968] Polishing utilization of new employment/education model

> @corbinSanders Looks like there are some test failures. Could you check on those? These tests passed locally. Could I get a cache reset?

[ENG-968] Polishing utilization of new employment/education model

> Are you up to date with develop? Dawn just updated the feature branch. Rebased my branch. Rerunning. Both of those tests are passing locally 🤔

API Deprecations

There is a query parameter deprecation issue with check_authorization. https://github.com/sigmavirus24/github3.py/blob/70835a65402bfe95cb3b3a875221e613c654f45b/src/github3/github.py#L523