Ben Corbett

Results 82 comments of Ben Corbett

Wow, thanks @trws @willkill07 so much for digging into this!

Bump. I also think this would be a nice feature to have.

@rrsettgast @wrtobin I think you guys should give this a look over. I commented a few of the pain points. It passes most of the integrated tests on ruby (except...

> Thanks. > > I would start by merging it as it is now. In the future, I would add the option to specify via command line a json file...

Just looking at the first few lines of the gdb output it looks like `arrayManipulation::emplace` is being passed a `nullptr`. Unfortunately the few frames above this argument is optimized out...

Yeah after a tad more thought I doubt it's an OOM error since in those cases we usually see the error from Umpire directly. But certainly if it's not terribly...

I measured the impact of `eigsolve_eager` and it is small but noticeable. The following is with `eigensolve_krylovdim=10` and `eigensolve_maxiter=10` with an already well converged MPS (what I imagine the optimal...

> > The difference should get larger as you make `eigsolve_krylovdim` larger. That's what I expect as well, but 10 with 10 iterations is already 33x larger than ITensors` default.

> > `eager` only relates to the number of Krylov states per iteration/restart, not the number of iterations/restarts. So it won't reach `maxiter` even if `eager=false` if it is converged...

@mtfishman I updated the docs and tests, but I seem to be having trouble with the formatting. For one the formatter updated 100+ files which I did not touch, but...