coraza icon indicating copy to clipboard operation
coraza copied to clipboard

Published 20 hours ago • verified publisher icon corazawaf

Revert "tests: use assert library for tests"

Open jcchavezs opened this issue 1 year ago • 2 comments

Reverts corazawaf/coraza#298 as agreed in https://github.com/corazawaf/coraza/pull/298#issuecomment-1207895386

Ping @anuraaga

jcchavezs avatar Aug 08 '22 21:08 jcchavezs

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarcloud[bot] avatar Aug 08 '22 21:08 sonarcloud[bot]

Thanks @jcchavezs sorry about this

anuraaga avatar Aug 09 '22 00:08 anuraaga

I will get this merged today so we can finally rebase v3/dev on top of this.

jcchavezs avatar Aug 18 '22 08:08 jcchavezs

@jcchavezs please fix lint issues so we can approve

jptosso avatar Aug 18 '22 14:08 jptosso

JC, maybe we could skip this, as tinygo support won't reach v2

jptosso avatar Aug 18 '22 14:08 jptosso

JC, maybe we could skip this, as tinygo support won't reach v2

Yeah but I think it would be cool if we get v3 to be v2 compliant for correctness.

jcchavezs avatar Aug 18 '22 19:08 jcchavezs

Once this gets merged I will port some test changes like all the t.Run introduced in this PR https://github.com/corazawaf/coraza/pull/298/files#diff-70802fcd97ffda50ed3469a4b405b7e4f399592753c208d4c054330b053a9946R79

jcchavezs avatar Aug 18 '22 19:08 jcchavezs