coraza icon indicating copy to clipboard operation
coraza copied to clipboard

Drop Transaction.ProcessRequest

Open jcchavezs opened this issue 1 year ago • 2 comments

Summary

I'd like to propose to drop Transaction.ProcessRequest from the coraza package (see https://github.com/corazawaf/coraza/blob/ddbce89245135ea7243ff1b5399ec2ac786479e9/transaction.go#L452). The reason is that it is too specific and makes assumptions about the usage of the library in the core package. Ideally this kind of specific helpers should go to another package or be an example.

On a side not, net/http package isn't supported by tinygo making this inconvenient, that was my original motivation for this request but if I could ignore this function in tiny_go, I believe this is a too specific function.

cc @jptosso @fzipi

jcchavezs avatar Jul 11 '22 07:07 jcchavezs

I agree with moving this function and all transaction helpers to another package, like coraza/v3/utils/http

jptosso avatar Jul 11 '22 20:07 jptosso

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Aug 11 '22 03:08 github-actions[bot]

Implemented in v3 https://github.com/corazawaf/coraza/pull/296

jptosso avatar Aug 18 '22 03:08 jptosso