talk icon indicating copy to clipboard operation
talk copied to clipboard

Moderation Pipeline will never run external phases when PREMOD is set

Open bastiankistner opened this issue 8 months ago • 2 comments

Expected behavior: External moderation phases are not skipped when pre-moderation phase is enabled.

Actual behavior: When pre-moderation is enabled in admin settings, external moderation phases will never run as the statusPreModerate.ts will set a status and therefore the pipeline will abort early.


I wonder if it really makes sense to run the statusPreModerate phase before external phases. When premod is disabled and an external phase is unavailable (e.g. due to network issues or errors), this could potentially result in every comment being published immediately.

However, if external phases would run before the premod phase, they would have the opportunity to set a status and if not, the premod phase would still ensure that moderation is required.

The only necessary change would be to change the order of the very last phases. Instead of running external phases last, they should run before any phase that returns a status.

bastiankistner avatar Jun 05 '24 14:06 bastiankistner