multisig icon indicating copy to clipboard operation
multisig copied to clipboard

add check on transaction creation

Open CanardMandarin opened this issue 2 years ago • 0 comments

Hello,

I'm making a series of pull request. Feel free to refuse the ones that aren't meaningful to you.

This pull request updates the instructions create_transaction and execute_transaction.

The instruction create_transaction now ensures that the multisig_signer account is present as a signer in the account list. I removed the multisig_signer account in the execute_transaction instruction, as it is already included in the "remaining accounts".

Pros:

  • Transaction where the multisig_signer account is not present or not a signer are refused.
  • ExecuteTransaction instruction size is now smaller and consumes less compute units.

Con:

  • Require frontend apps to update their code

CanardMandarin avatar Nov 19 '22 14:11 CanardMandarin