backpack icon indicating copy to clipboard operation
backpack copied to clipboard
verified publisher icon coral-xyz

remove duplicate WithAuth components

Open tomlinton opened this issue 3 years ago • 5 comments

Screenshot 2023-04-12 at 1 17 00 PM

tomlinton avatar Apr 12 '23 01:04 tomlinton

But it was fixed 😅

tomlinton avatar Apr 13 '23 23:04 tomlinton

@callensm is this issue about removing the WithAuth file at packages/app-extension/src/components/Unlocked/WithAuth.tsx and all the imports for the same to use the one at packages/recoil/src/context ? I would like to help on the same, TIA

adarshlilha avatar Apr 14 '23 19:04 adarshlilha

But it was fixed 😅

apparently the mobile package utilized the one i removed and didn't show up in my code search 😕

they need to be consolidated into the one in the recoil package.

callensm avatar Apr 14 '23 19:04 callensm

The one used in extension is using WithDrawer but the one used in mobile app is not using it. So should we abstract out WithDrawer for both mobile and extension or should we keep it in WithAuth for both.

Anubhav311 avatar Apr 14 '23 19:04 Anubhav311

@peterpme

callensm avatar Apr 14 '23 20:04 callensm