backpack icon indicating copy to clipboard operation
backpack copied to clipboard

Update "Accept" link color in notifications for friend requests

Open trucy opened this issue 1 year ago • 12 comments

Screenshot 2023-04-04 at 12 56 44 PM

Currently blue in light mode and rgb(52, 152, 219) for dark mode, these should be:

  • #0057EB or rgb(0,87,235) for light mode
  • #4C94FF or rgb(76,148,255) for dark mode

trucy avatar Apr 04 '23 18:04 trucy

Hi trucy, I would like to do this one. Can you please assign it to me.

Anubhav311 avatar Apr 04 '23 18:04 Anubhav311

@trucy is that about the "Accept" button?

Merdi-kim avatar Apr 04 '23 19:04 Merdi-kim

@Merdi-kim yes! will edit the poorly worded issue name :)

trucy avatar Apr 04 '23 20:04 trucy

Hey @trucy , Created a PR for this issue https://github.com/coral-xyz/backpack/pull/3598

This PR updated the values of the color for the Accept link color

spantheslayer avatar Apr 04 '23 20:04 spantheslayer

Hi @trucy I have raised a PR that will resolve this issue without updating UI at any other place, as I did not changed the color on global level. Kindly review and merge that PR. Thank you!

hsnice16 avatar Apr 04 '23 20:04 hsnice16

Hi @trucy the color of "Accept" on this screen should also be change? Screenshot 2023-04-06 at 10 44 08 PM

Anubhav311 avatar Apr 06 '23 17:04 Anubhav311

Hey @trucy, Is this issue open to everyone? Can i work on this issue ?

ShivamPandey00 avatar Apr 12 '23 16:04 ShivamPandey00

@Anubhav311 yes! should actually be a global find/replace of anywhere using blue as a color

trucy avatar Apr 20 '23 16:04 trucy

@trucy got it... just pushing the change

Anubhav311 avatar Apr 20 '23 19:04 Anubhav311

I've updated the blue color globally. Please take a look: https://github.com/coral-xyz/backpack/pull/3602

Anubhav311 avatar Apr 20 '23 19:04 Anubhav311

Some PRs created for this issue were closed without giving any reason. Should I start working on this?

manancodes avatar Dec 27 '23 17:12 manancodes

Hi Trucy , I would want to take this issue , can you please assign it to me ?

Chandradeep-Pra avatar Mar 26 '24 12:03 Chandradeep-Pra