backpack icon indicating copy to clipboard operation
backpack copied to clipboard

Accepting a contact request shouldn't show pending banner

Open trucy opened this issue 2 years ago • 5 comments

Accepting a contact request shows a success toast, but the wrong banner and popover

Screenshot 2023-02-06 at 8 07 17 PM

This banner and dropdown are incorrect if I just accepted a contact request Screenshot 2023-02-06 at 8 07 30 PM Screenshot 2023-02-06 at 8 07 41 PM

The profile shows the right contact status

Screenshot 2023-02-06 at 8 08 42 PM

trucy avatar Feb 07 '23 15:02 trucy

Hi, beginner here. You'd like the pop-up gone, is that correct?

tauqeer1040 avatar Mar 29 '23 18:03 tauqeer1040

Hi , Assign this to me if nobody has fixed this issue. The pull request is here.Please verify

tejasma avatar Apr 01 '23 07:04 tejasma

Hi @trucy, Would you mind assigning the issue to me? I think the issue is with the MessageOptions Component not updating the areFriends member of the friendshipValue state variable. Updating it when the remoteRequested is true, should fix the issue. Thanks.

RashulChutani avatar Apr 09 '23 12:04 RashulChutani

Hi @trucy I managed to fix the issue. Here is a video that shows the corrected workflow:

https://user-images.githubusercontent.com/41239718/230927705-c7cf92c1-7c2e-41b0-afd2-2621e85789dc.mp4

The corresponding PR is linked. Thanks.

RashulChutani avatar Apr 10 '23 15:04 RashulChutani

Hi @trucy, Would you please mind reviewing my PR? I will be extremely thankful.

RashulChutani avatar Apr 17 '23 18:04 RashulChutani