backpack icon indicating copy to clipboard operation
backpack copied to clipboard

Published 20 hours ago • verified publisher icon coral-xyz

Add better typing for toString

Open hkirat opened this issue 2 years ago • 7 comments

Seems like a common theme of the app breaking is Cant read property toString of undefiend . We should wrap all toString calls in a try catch so that the app doesn't break, and if it does we know where exactly the issue lies

More details - https://discord.com/channels/985994296337498182/1035923763570675832/1042574330808242278

hkirat avatar Nov 17 '22 03:11 hkirat

It seems like we should be able to fix this by working on our typing a bit, particularly removing not null assertions and any types.

tomlinton avatar Nov 17 '22 08:11 tomlinton

Yeah better types is definitely the cleaner way to do this

hkirat avatar Nov 17 '22 11:11 hkirat

I would like to work on this issue. Please assign it to me. Thanks.

SlokAks avatar Mar 28 '23 19:03 SlokAks

@SlokAks go for it!

hkirat avatar Mar 28 '23 19:03 hkirat

Hi @hkirat . If the assignee is not working on this, can I please take it over?

DeepakSR-12 avatar Apr 10 '23 15:04 DeepakSR-12

Hi @DeepakSR-12, was busy with office work for last week. I am currently working on it.

SlokAks avatar Apr 10 '23 15:04 SlokAks

Sure thing @SlokAks . If you wish to delegate it or would like to collaborate on this issue, please do ping me.

DeepakSR-12 avatar Apr 10 '23 15:04 DeepakSR-12