backpack icon indicating copy to clipboard operation
backpack copied to clipboard

Stripe via popups

Open hkirat opened this issue 1 year ago • 2 comments

The PR adds three things

  1. Opens stripe in a popup whenever a user wants to unramp. Before this we showed it in the app-extension but that won't work until stripe supports iframes
  2. Adds backend logic to store all stripe transactions, and listens to webhooks from stripe to store transaction status into the DB. This was originally written to show a better feedback to the user on the extension. We're not doing that anymore. This can be used in the future for users to be able to track their transactions right from their wallet.
  3. Moves all onramp logic to the auth folder after discussion with the team as to the best place for it to be for now.

hkirat avatar Oct 29 '22 15:10 hkirat

@hkirat is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 29 '22 15:10 vercel[bot]

I think the hasura change summary task failed to run because the github action is run in the context of your fork

so the GITHUB_TOKEN env var it uses isn't valid for https://github.com/coral-xyz/backpack

will look into this

wentokay avatar Oct 29 '22 15:10 wentokay

@wentokay can I merge in this one? Would be good to get this in before the next release since we might need to make stripe public by then. If the DB migration stuff is causing issues maybe we can just run the migration script locally?

hkirat avatar Oct 31 '22 17:10 hkirat

could you merge this commit into this branch please?

https://github.com/coral-xyz/backpack/commit/7ec9e69bcbae37e5c3661ba736221167ac781ce1 (branch: wen/stripe-amends)

it just runs yarn from root (stripe was missing from the root yarn.lock) and yarn zeus again from backend/workers/auth

wentokay avatar Oct 31 '22 18:10 wentokay

figured out how to make a PR here https://github.com/hkirat/backpack/pull/3

but I think you might've done the changes now anyway

wentokay avatar Oct 31 '22 18:10 wentokay