backpack icon indicating copy to clipboard operation
backpack copied to clipboard

Unable to connect my wallet on xnft.gg

Open hkirat opened this issue 1 year ago • 3 comments

Screenshot 2022-10-22 at 10 12 58 PM

hkirat avatar Oct 22 '22 16:10 hkirat

Had to close and re-open chrome

hkirat avatar Oct 22 '22 16:10 hkirat

Way to reproduce - https://discord.com/channels/985994296337498182/1011846320677462137/1033853025913155595

hkirat avatar Oct 23 '22 21:10 hkirat

Happened again here - https://discord.com/channels/985994296337498182/1011846320677462137/1035603903024210010

hkirat avatar Oct 28 '22 17:10 hkirat

If you have an approval prompt open and you don't either approve/deny this will happen. Is that what is happening here?

tomlinton avatar Nov 01 '22 21:11 tomlinton

Maybe, I'm unsure if I had a lingering approval prompt open. Maybe I didn't approve or deny on one of them (since I have two wallets)

hkirat avatar Nov 02 '22 00:11 hkirat

It sounds like it is working as intended (restricting the number of approval popups to one) but it also seems to be causing some confusion. Will have to think about a solution.

tomlinton avatar Nov 02 '22 07:11 tomlinton

Maybe if a user deliberately clicks on Connect we should trigger a new popup?

hkirat avatar Nov 02 '22 15:11 hkirat

Would make sense to close the old one and open the new one.

armaniferrante avatar Nov 02 '22 15:11 armaniferrante

Yeah that should do it

hkirat avatar Nov 02 '22 15:11 hkirat

We'd need to figure out when a user clicked on the connect button vs was auto connected else this'll get very confusing to the end user when popups close and re-open automatically on auto connects.

hkirat avatar Nov 02 '22 16:11 hkirat

That was built to prevent sites spamming popups, closing the old one and opening a new one has basically the same problem as spamming popups everywhere

tomlinton avatar Nov 02 '22 16:11 tomlinton

Makes sense. I think it makes sense to close this for now then. I'll keep an eye out for when this happens again to see if I'm missing an open popup. Will re-open if that's not the case (looking at the locking logic I most probably had a lingering popup). Thanks for the clarification @tomlinton

hkirat avatar Nov 02 '22 17:11 hkirat

It might make sense to just focus the open popup (if possible)

tomlinton avatar Nov 02 '22 17:11 tomlinton

Looking at chrome docs it may not be possible. It's possible to open it in panel mode it seems but that flag is not on by default so it'll go out of focus for most users. Ref https://stackoverflow.com/questions/13574825/chrome-extension-create-window-alwaysontop

hkirat avatar Nov 02 '22 17:11 hkirat