backpack icon indicating copy to clipboard operation
backpack copied to clipboard

Published 20 hours ago • verified publisher icon coral-xyz

xNFT skeleton component loader

Open armaniferrante opened this issue 1 year ago • 5 comments

Right now there's no loading indicator on the xnft applications page. We should add a skeleton component.

armaniferrante avatar Oct 17 '22 13:10 armaniferrante

Simple loader/spinner or a specific design?

arihantbansal avatar Oct 17 '22 15:10 arihantbansal

A <Skeleton> component of apps. See the existing usage of Skeletons in the repo for examples. https://github.com/coral-xyz/backpack/blob/b1414df0ea197746008a1cb2caee3a8d2f9d3300/packages/app-extension/src/components/Unlocked/Balances/BalanceSummaryWidget.tsx#L75-L79

armaniferrante avatar Oct 17 '22 15:10 armaniferrante

There's logic in https://github.com/coral-xyz/backpack/pull/1090/files#diff-da6bbbe287bdc7f63e59e4e585aaa26d8d8672baad3790b794dbf68ed49c3349R32 to add a simple loader for xnfts. @arihantbansal if you'd like to pick this up could you either fork out of hkirat:hkirat/new-way-of-rendering or wait until it gets merged in to avoid conflicts?

hkirat avatar Oct 17 '22 16:10 hkirat

Alright, will fork of yours.

arihantbansal avatar Oct 17 '22 16:10 arihantbansal

@arihantbansal that PR is in so feel free to work out of master

hkirat avatar Oct 18 '22 00:10 hkirat