anchor icon indicating copy to clipboard operation
anchor copied to clipboard

impl signer now includes deref impl signer

Open cavemanloverboy opened this issue 1 year ago • 6 comments

Now that Signer is implemented for all Deref<Target = impl Signer> within solana-sdk, we can remove this from the client without introducing breaking changes. This simplifies the code and allows rust-analyzer to better infer types.

cavemanloverboy avatar Nov 18 '23 19:11 cavemanloverboy

@cavemanloverboy is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 18 '23 19:11 vercel[bot]

Now that Signer is implemented for all Deref<Target = impl Signer> within solana-sdk, we can remove this from the client without introducing breaking changes.

Unfortunately not because solana-labs/solana#32181 requires ^1.17 but we still support 1.16.

Also, nonblocking client needs to be updated too.

updated nonblocking client, and removed unused Deref import. I guess we can wait until 1.17 ships?

cavemanloverboy avatar Nov 18 '23 21:11 cavemanloverboy

updated nonblocking client, and removed unused Deref import. I guess we can wait until 1.17 ships?

Yes, I think it's better to wait until 1.17 adoption before we make it the minimum version.

acheroncrypto avatar Nov 18 '23 21:11 acheroncrypto

updated nonblocking client, and removed unused Deref import. I guess we can wait until 1.17 ships?

Yes, I think it's better to wait until 1.17 adoption before we make it the minimum version.

🫡

cavemanloverboy avatar Nov 18 '23 22:11 cavemanloverboy

this may be ready to go soon

cavemanloverboy avatar Jan 26 '24 08:01 cavemanloverboy

bump

cavemanloverboy avatar Mar 09 '24 03:03 cavemanloverboy