Trainer icon indicating copy to clipboard operation
Trainer copied to clipboard

Run test_run() every time that saves a checkpoint and not in the epochs end.

Open Edresson opened this issue 3 years ago • 4 comments

Currently, we save checkpoints without audio samples for each one. In this way, we cannot evaluate the models correctly. My suggestion is to run test_run() every time that we save a checkpoint.

Edresson avatar May 10 '22 16:05 Edresson

Hi @Edresson, If you are accepting contributions, I wanted to check if I can help with implementing this feature request if not done already. I am looking to start with open source development and thought coqui would be a great platform. Please let me know. I am open to working on other feature requests as well.

pranavpawar3 avatar Jul 05 '22 20:07 pranavpawar3

Hi @pranavpawar3 , contributions are always welcome on all Coqui repositories. Feel free to contribute :). @erogol This feature is not already implemented and is it welcome, right?

Edresson avatar Jul 07 '22 11:07 Edresson

Yep not implemented yet. Feel free to shoot a PR

erogol avatar Jul 07 '22 11:07 erogol

Thanks @Edresson @erogol, I will try to make a PR soon! I shall write here if I have any questions.

pranavpawar3 avatar Jul 07 '22 14:07 pranavpawar3