TTS icon indicating copy to clipboard operation
TTS copied to clipboard

Add Delightful-TTS model

Open loganhart02 opened this issue 2 years ago • 5 comments

model implementation from: https://arxiv.org/pdf/2110.12612.pdf

loganhart02 avatar Oct 25 '22 08:10 loganhart02

@erogol The most recent push of code I know works and is currently training a model. after I confirm it converges Ill clean up the code and write the docs for the model

loganhart02 avatar Nov 01 '22 19:11 loganhart02

@erogol I'm working on fixing a bug in unittest but the code to the model is ready to start the review

loganhart02 avatar Nov 30 '22 13:11 loganhart02

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.

stale[bot] avatar Jan 20 '23 15:01 stale[bot]

Any idea when this will be merged? And will it have a pre-trained model?

iamkhalidbashir avatar Feb 23 '23 12:02 iamkhalidbashir

is this PR for Delightful TTS 1 or Delightful TTS 2 (https://arxiv.org/abs/2207.04646)

iamkhalidbashir avatar Mar 14 '23 08:03 iamkhalidbashir

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.

stale[bot] avatar May 12 '23 20:05 stale[bot]

@loganhart420 lets wrap up this PR

erogol avatar May 14 '23 10:05 erogol

Would we have a trained model ?

On Sun, 14 May 2023 at 3:38 PM Eren Gölge @.***> wrote:

@loganhart420 https://github.com/loganhart420 lets wrap up this PR

— Reply to this email directly, view it on GitHub https://github.com/coqui-ai/TTS/pull/2095#issuecomment-1546867214, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGS5WW24GACUO25ME47RDS3XGCY35ANCNFSM6AAAAAARNXTJQE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Mr. Bashir, CEO, AMOXT Pvt. Ltd

iamkhalidbashir avatar May 14 '23 10:05 iamkhalidbashir

@loganhart420 lets wrap up this PR

doing it now, should I just put the pertained weights in a draft release?

loganhart02 avatar May 14 '23 13:05 loganhart02

Would we have a trained model ? On Sun, 14 May 2023 at 3:38 PM Eren Gölge @.> wrote: @loganhart420 https://github.com/loganhart420 lets wrap up this PR — Reply to this email directly, view it on GitHub <#2095 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGS5WW24GACUO25ME47RDS3XGCY35ANCNFSM6AAAAAARNXTJQE . You are receiving this because you are subscribed to this thread.Message ID: @.> -- Mr. Bashir, CEO, AMOXT Pvt. Ltd

yea

loganhart02 avatar May 14 '23 13:05 loganhart02

is this PR for Delightful TTS 1 or Delightful TTS 2 (https://arxiv.org/abs/2207.04646)

1

loganhart02 avatar May 14 '23 13:05 loganhart02

Awesome!

On Sun, 14 May 2023 at 6:15 PM logan hart @.***> wrote:

Would we have a trained model ? On Sun, 14 May 2023 at 3:38 PM Eren Gölge @.> wrote: @loganhart420 https://github.com/loganhart420 https://github.com/loganhart420 https://github.com/loganhart420 lets wrap up this PR — Reply to this email directly, view it on GitHub <#2095 (comment) https://github.com/coqui-ai/TTS/pull/2095#issuecomment-1546867214>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGS5WW24GACUO25ME47RDS3XGCY35ANCNFSM6AAAAAARNXTJQE https://github.com/notifications/unsubscribe-auth/AGS5WW24GACUO25ME47RDS3XGCY35ANCNFSM6AAAAAARNXTJQE . You are receiving this because you are subscribed to this thread.Message ID: @.> -- Mr. Bashir, CEO, AMOXT Pvt. Ltd

yea

— Reply to this email directly, view it on GitHub https://github.com/coqui-ai/TTS/pull/2095#issuecomment-1546898332, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGS5WW4NFZEHQJM7LLZ4RYTXGDLHDANCNFSM6AAAAAARNXTJQE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Mr. Bashir, CEO, AMOXT Pvt. Ltd

iamkhalidbashir avatar May 14 '23 13:05 iamkhalidbashir

@erogol I've tested everything on local and all tests are fixed but I keep on getting a pyworld failed install so I'm going to let you decide when to merge. I think it might be a problem with our GitHub tests since it's failing to install TTS. PR should be ready tho

loganhart02 avatar May 18 '23 03:05 loganhart02

@loganhart420 you should rebase the current dev. It may fix the issue as all the tests are passing on the dev.

erogol avatar May 18 '23 09:05 erogol

or just remove pyworld from requirements. We dropped it in the latest version of TTS

erogol avatar May 18 '23 09:05 erogol

Does this PR include the model?

kubasienki avatar Jun 15 '23 11:06 kubasienki

@loganhart420 can you fix the CI issues?

erogol avatar Jun 16 '23 09:06 erogol